Code review comment for ~jugmac00/launchpadlib:add-configuration-file-for-rtd

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

> Does the python section of the config basically tell it to build the docs from that path, to a `docs` directory, using pip?

No.

This refers to the `extras_require` section in the `setup.py`.
https://git.launchpad.net/launchpadlib/tree/setup.py#n93

So the mentioned specification would translate to

```
pip install .[docs]
```

That is install the package plus the extra requirements specified in the `docs` `extras_require` section.

Another example would be the wtforms library - when you want to have the email validator enabled, you need to install it via `pip install wtforms[email_validator]`
https://github.com/wtforms/wtforms/blob/0524993ee57a957c8444df2b090c00464ef9bb2a/setup.cfg#L37

> I notice the other `.readthedocs.yaml` in our repos don't use `fail_on_warning`. I think it makes sense to add it, but maybe we also want to add it in the other ones to keep them consistent!

Indeed, it makes sense to use it, as otherwise technical debt can pile or even worse things break unnoticed.

Currently, it is very tedious to apply changes to all our repositories, that is why I created an item for the next roadmap cycle to introduce tooling for that.
https://docs.google.com/spreadsheets/d/1rmlPtCWr-nlIDE26Et_okt4yC4RRQX5r6wLik-M9WpM/edit#gid=1800655972

« Back to merge proposal