Code review comment for ~jugmac00/launchpadlib:add-configuration-file-for-rtd

Revision history for this message
Ines Almeida (ines-almeida) wrote :

Looks good to me, although I'm not into the details of readthedocs.yaml

Does the python section of the config basically tell it to build the docs from that path, to a `docs` directory, using pip?

I notice the other `.readthedocs.yaml` in our repos don't use `fail_on_warning`. I think it makes sense to add it, but maybe we also want to add it in the other ones to keep them consistent!

review: Approve

« Back to merge proposal