Merge ~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning into launchpad:master

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 532e63232dae469a645a8161c3e2fbee0df067db
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning
Merge into: launchpad:master
Diff against target: 52 lines (+19/-0)
2 files modified
lib/lp/registry/model/person.py (+1/-0)
lib/lp/registry/tests/test_team.py (+18/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+431440@code.launchpad.net

Commit message

Add `livefs` to skipset for consistency warning

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Jürgen Gmach (jugmac00) :
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/lp/registry/model/person.py b/lib/lp/registry/model/person.py
index e2f7078..bfdee1a 100644
--- a/lib/lp/registry/model/person.py
+++ b/lib/lp/registry/model/person.py
@@ -2716,6 +2716,7 @@ class Person(
2716 ("karma", "person"),2716 ("karma", "person"),
2717 ("karmacache", "person"),2717 ("karmacache", "person"),
2718 ("karmatotalcache", "person"),2718 ("karmatotalcache", "person"),
2719 ("livefs", "owner"),
2719 ("logintoken", "requester"),2720 ("logintoken", "requester"),
2720 ("personlanguage", "person"),2721 ("personlanguage", "person"),
2721 ("personlocation", "person"),2722 ("personlocation", "person"),
diff --git a/lib/lp/registry/tests/test_team.py b/lib/lp/registry/tests/test_team.py
index 7a95184..c2166cd 100644
--- a/lib/lp/registry/tests/test_team.py
+++ b/lib/lp/registry/tests/test_team.py
@@ -26,11 +26,13 @@ from lp.registry.interfaces.person import IPersonSet, ITeamPublic
26from lp.registry.interfaces.teammembership import TeamMembershipStatus26from lp.registry.interfaces.teammembership import TeamMembershipStatus
27from lp.registry.model.persontransferjob import PersonTransferJob27from lp.registry.model.persontransferjob import PersonTransferJob
28from lp.services.database.interfaces import IMasterStore28from lp.services.database.interfaces import IMasterStore
29from lp.services.features.testing import FeatureFixture
29from lp.services.identity.interfaces.emailaddress import IEmailAddressSet30from lp.services.identity.interfaces.emailaddress import IEmailAddressSet
30from lp.services.identity.model.emailaddress import EmailAddress31from lp.services.identity.model.emailaddress import EmailAddress
31from lp.services.mail.sendmail import format_address_for_person32from lp.services.mail.sendmail import format_address_for_person
32from lp.services.messages.interfaces.message import IDirectEmailAuthorization33from lp.services.messages.interfaces.message import IDirectEmailAuthorization
33from lp.soyuz.enums import ArchiveStatus34from lp.soyuz.enums import ArchiveStatus
35from lp.soyuz.interfaces.livefs import LIVEFS_FEATURE_FLAG
34from lp.testing import (36from lp.testing import (
35 TestCaseWithFactory,37 TestCaseWithFactory,
36 login_celebrity,38 login_celebrity,
@@ -604,6 +606,22 @@ class TestVisibilityConsistencyWarning(TestCaseWithFactory):
604 self.team.visibilityConsistencyWarning(PersonVisibility.PRIVATE)606 self.team.visibilityConsistencyWarning(PersonVisibility.PRIVATE)
605 )607 )
606608
609 def test_no_warning_for_livefs(self):
610 with FeatureFixture({LIVEFS_FEATURE_FLAG: "on"}):
611 member = self.factory.makePerson()
612 self.team.addMember(
613 member, member, status=TeamMembershipStatus.APPROVED
614 )
615 self.factory.makeLiveFS(
616 registrant=member,
617 owner=self.team,
618 )
619 self.assertIsNone(
620 self.team.visibilityConsistencyWarning(
621 PersonVisibility.PRIVATE
622 )
623 )
624
607625
608class TestPersonJoinTeam(TestCaseWithFactory):626class TestPersonJoinTeam(TestCaseWithFactory):
609627

Subscribers

People subscribed via source and target branches

to status/vote changes: