Merge ~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning into launchpad:master

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 532e63232dae469a645a8161c3e2fbee0df067db
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning
Merge into: launchpad:master
Diff against target: 52 lines (+19/-0)
2 files modified
lib/lp/registry/model/person.py (+1/-0)
lib/lp/registry/tests/test_team.py (+18/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+431440@code.launchpad.net

Commit message

Add `livefs` to skipset for consistency warning

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Jürgen Gmach (jugmac00) :
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/model/person.py b/lib/lp/registry/model/person.py
2index e2f7078..bfdee1a 100644
3--- a/lib/lp/registry/model/person.py
4+++ b/lib/lp/registry/model/person.py
5@@ -2716,6 +2716,7 @@ class Person(
6 ("karma", "person"),
7 ("karmacache", "person"),
8 ("karmatotalcache", "person"),
9+ ("livefs", "owner"),
10 ("logintoken", "requester"),
11 ("personlanguage", "person"),
12 ("personlocation", "person"),
13diff --git a/lib/lp/registry/tests/test_team.py b/lib/lp/registry/tests/test_team.py
14index 7a95184..c2166cd 100644
15--- a/lib/lp/registry/tests/test_team.py
16+++ b/lib/lp/registry/tests/test_team.py
17@@ -26,11 +26,13 @@ from lp.registry.interfaces.person import IPersonSet, ITeamPublic
18 from lp.registry.interfaces.teammembership import TeamMembershipStatus
19 from lp.registry.model.persontransferjob import PersonTransferJob
20 from lp.services.database.interfaces import IMasterStore
21+from lp.services.features.testing import FeatureFixture
22 from lp.services.identity.interfaces.emailaddress import IEmailAddressSet
23 from lp.services.identity.model.emailaddress import EmailAddress
24 from lp.services.mail.sendmail import format_address_for_person
25 from lp.services.messages.interfaces.message import IDirectEmailAuthorization
26 from lp.soyuz.enums import ArchiveStatus
27+from lp.soyuz.interfaces.livefs import LIVEFS_FEATURE_FLAG
28 from lp.testing import (
29 TestCaseWithFactory,
30 login_celebrity,
31@@ -604,6 +606,22 @@ class TestVisibilityConsistencyWarning(TestCaseWithFactory):
32 self.team.visibilityConsistencyWarning(PersonVisibility.PRIVATE)
33 )
34
35+ def test_no_warning_for_livefs(self):
36+ with FeatureFixture({LIVEFS_FEATURE_FLAG: "on"}):
37+ member = self.factory.makePerson()
38+ self.team.addMember(
39+ member, member, status=TeamMembershipStatus.APPROVED
40+ )
41+ self.factory.makeLiveFS(
42+ registrant=member,
43+ owner=self.team,
44+ )
45+ self.assertIsNone(
46+ self.team.visibilityConsistencyWarning(
47+ PersonVisibility.PRIVATE
48+ )
49+ )
50+
51
52 class TestPersonJoinTeam(TestCaseWithFactory):
53

Subscribers

People subscribed via source and target branches

to status/vote changes: