Code review comment for ~jugmac00/launchpad:revisionsstatusreport-attach-and-setlog-now-accept-file-object

Revision history for this message
Colin Watson (cjwatson) wrote :

I'd consider changing `CIUpload` to use this in the same MP. Probably not a major issue in this case, but when doing refactorings like this in the past I've sometimes found that changing the calling code along with the underlying refactoring causes me to notice problems I'd otherwise have missed.

review: Approve

« Back to merge proposal