Code review comment for ~jugmac00/launchpad:populate-signedcodeofconduct.affirmed

Attention: this is work in progress - the test currently does not pass.

It fails / errors with:

 lp.scripts.tests.test_garbo.TestGarbo.test_PopulateSignedCodeOfConductAffirmed

Error in test lp.scripts.tests.test_garbo.TestGarbo.test_PopulateSignedCodeOfConductAffirmed
Traceback (most recent call last):
testtools.testresult.real._StringException: librarian-log: {{{
2021-10-14 21:06:29+0530 [-] Loading /home/jugmac00/launchpad/launchpad/daemons/librarian.tac...
2021-10-14 21:06:31+0530 [-] Loaded.
2021-10-14 21:06:31+0530 [-] twistd 20.3.0 (/home/jugmac00/launchpad/launchpad/env/bin/python3 3.5.2) starting up.
2021-10-14 21:06:31+0530 [-] reactor class: twisted.internet.epollreactor.EPollReactor.
2021-10-14 21:06:31+0530 [-] FileUploadFactory starting on 46629
2021-10-14 21:06:31+0530 [-] Starting factory <lp.services.librarianserver.libraryprotocol.FileUploadFactory object at 0x7efd137e7048>
2021-10-14 21:06:31+0530 [-] Site starting on 33159
2021-10-14 21:06:31+0530 [-] Starting factory <twisted.web.server.Site object at 0x7efd13798cc0>
2021-10-14 21:06:31+0530 [-] FileUploadFactory starting on 40011
2021-10-14 21:06:31+0530 [-] Starting factory <lp.services.librarianserver.libraryprotocol.FileUploadFactory object at 0x7efd131386a0>
2021-10-14 21:06:31+0530 [-] Site starting on 40651
2021-10-14 21:06:31+0530 [-] Starting factory <twisted.web.server.Site object at 0x7efd130f1f98>
2021-10-14 21:06:31+0530 [-] Not using upstream librarian
2021-10-14 21:06:31+0530 [-] daemon ready!
}}}

Traceback (most recent call last):
  File "/home/jugmac00/launchpad/launchpad/lib/lp/scripts/tests/test_garbo.py", line 448, in setUp
    self.runHourly()
  File "/home/jugmac00/launchpad/launchpad/lib/lp/scripts/tests/test_garbo.py", line 479, in runHourly
    collector.main()
  File "/home/jugmac00/launchpad/launchpad/lib/lp/scripts/garbo.py", line 1877, in main
    raise SilentLaunchpadScriptFailure(self.failure_count)
lp.services.scripts.base.SilentLaunchpadScriptFailure: 1

The "populator" itself works, ie when instantiating it with `PopulateSignedCodeOfConductAffirmed(log=None)`, which is even more puzzling.