Merge ~jugmac00/launchpad:fix-docstring-for-UnusedPOTMsgSetPruner._get_msgset_ids_to_remove into launchpad:master

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 87f4ea1eea2ab4133f3ce419a76b4b674900229a
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad:fix-docstring-for-UnusedPOTMsgSetPruner._get_msgset_ids_to_remove
Merge into: launchpad:master
Diff against target: 31 lines (+3/-3)
1 file modified
lib/lp/scripts/garbo.py (+3/-3)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+410138@code.launchpad.net

Commit message

fix docstring

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Good catch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/lp/scripts/garbo.py b/lib/lp/scripts/garbo.py
index f89c5f7..e2471dc 100644
--- a/lib/lp/scripts/garbo.py
+++ b/lib/lp/scripts/garbo.py
@@ -1358,7 +1358,7 @@ class UnusedPOTMsgSetPruner(TunableLoop):
1358 return self._get_msgset_ids_to_remove()1358 return self._get_msgset_ids_to_remove()
13591359
1360 def _get_msgset_ids_to_remove(self, ids=None):1360 def _get_msgset_ids_to_remove(self, ids=None):
1361 """Return a distrinct list IDs of the POTMsgSets to remove.1361 """Return a distinct list of IDs of the POTMsgSets to remove.
13621362
1363 :param ids: a list of POTMsgSet ids to filter. If ids is None,1363 :param ids: a list of POTMsgSet ids to filter. If ids is None,
1364 all unused POTMsgSet in the database are returned.1364 all unused POTMsgSet in the database are returned.
@@ -1974,7 +1974,7 @@ class BaseDatabaseGarbageCollector(LaunchpadCronScript):
1974 try:1974 try:
1975 tunable_loop.run()1975 tunable_loop.run()
1976 loop_logger.debug(1976 loop_logger.debug(
1977 "%s completed sucessfully.", loop_name)1977 "%s completed successfully.", loop_name)
1978 except Exception:1978 except Exception:
1979 loop_logger.exception("Unhandled exception")1979 loop_logger.exception("Unhandled exception")
1980 self.failure_count += 11980 self.failure_count += 1
@@ -2014,7 +2014,7 @@ class FrequentDatabaseGarbageCollector(BaseDatabaseGarbageCollector):
2014class HourlyDatabaseGarbageCollector(BaseDatabaseGarbageCollector):2014class HourlyDatabaseGarbageCollector(BaseDatabaseGarbageCollector):
2015 """Run every hour.2015 """Run every hour.
20162016
2017 Jobs we want to run fairly often but have noticable overhead go here.2017 Jobs we want to run fairly often but have noticeable overhead go here.
2018 """2018 """
2019 script_name = 'garbo-hourly'2019 script_name = 'garbo-hourly'
2020 tunable_loops = [2020 tunable_loops = [

Subscribers

People subscribed via source and target branches

to status/vote changes: