Merge ~jugmac00/launchpad:fix-docstring-for-UnusedPOTMsgSetPruner._get_msgset_ids_to_remove into launchpad:master

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 87f4ea1eea2ab4133f3ce419a76b4b674900229a
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad:fix-docstring-for-UnusedPOTMsgSetPruner._get_msgset_ids_to_remove
Merge into: launchpad:master
Diff against target: 31 lines (+3/-3)
1 file modified
lib/lp/scripts/garbo.py (+3/-3)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+410138@code.launchpad.net

Commit message

fix docstring

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Good catch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/scripts/garbo.py b/lib/lp/scripts/garbo.py
2index f89c5f7..e2471dc 100644
3--- a/lib/lp/scripts/garbo.py
4+++ b/lib/lp/scripts/garbo.py
5@@ -1358,7 +1358,7 @@ class UnusedPOTMsgSetPruner(TunableLoop):
6 return self._get_msgset_ids_to_remove()
7
8 def _get_msgset_ids_to_remove(self, ids=None):
9- """Return a distrinct list IDs of the POTMsgSets to remove.
10+ """Return a distinct list of IDs of the POTMsgSets to remove.
11
12 :param ids: a list of POTMsgSet ids to filter. If ids is None,
13 all unused POTMsgSet in the database are returned.
14@@ -1974,7 +1974,7 @@ class BaseDatabaseGarbageCollector(LaunchpadCronScript):
15 try:
16 tunable_loop.run()
17 loop_logger.debug(
18- "%s completed sucessfully.", loop_name)
19+ "%s completed successfully.", loop_name)
20 except Exception:
21 loop_logger.exception("Unhandled exception")
22 self.failure_count += 1
23@@ -2014,7 +2014,7 @@ class FrequentDatabaseGarbageCollector(BaseDatabaseGarbageCollector):
24 class HourlyDatabaseGarbageCollector(BaseDatabaseGarbageCollector):
25 """Run every hour.
26
27- Jobs we want to run fairly often but have noticable overhead go here.
28+ Jobs we want to run fairly often but have noticeable overhead go here.
29 """
30 script_name = 'garbo-hourly'
31 tunable_loops = [

Subscribers

People subscribed via source and target branches

to status/vote changes: