Merge ~jugmac00/launchpad-buildd:adjust-to-updated-ci-runner-option into launchpad-buildd:master

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 90f3d3daf3b85e98dc0f96da6737630c37f47ffc
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad-buildd:adjust-to-updated-ci-runner-option
Merge into: launchpad-buildd:master
Diff against target: 49 lines (+9/-3)
3 files modified
debian/changelog (+6/-0)
lpbuildd/target/run_ci.py (+1/-1)
lpbuildd/target/tests/test_run_ci.py (+2/-2)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+415201@code.launchpad.net

Commit message

Adjust to updated CI runner option

Description of the change

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

This mustn't land until the lpcraft change is on the stable channel in the snap store.

review: Approve
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

I just promoted the latest lpcraft snap build (incl. the updated option) to stable.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index b178963..bdca50b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
1launchpad-buildd (208) UNRELEASED; urgency=medium
2
3 * Adjust updated command line option for the CI runner.
4
5 -- Jürgen Gmach <juergen.gmach@canonical.com> Mon, 07 Feb 2022 15:17:09 +0000
6
1launchpad-buildd (207) bionic; urgency=medium7launchpad-buildd (207) bionic; urgency=medium
28
3 * Return results from individual CI jobs.9 * Return results from individual CI jobs.
diff --git a/lpbuildd/target/run_ci.py b/lpbuildd/target/run_ci.py
index 1fb6b0f..0dac760 100644
--- a/lpbuildd/target/run_ci.py
+++ b/lpbuildd/target/run_ci.py
@@ -103,7 +103,7 @@ class RunCI(BuilderProxyOperationMixin, Operation):
103 output_path = os.path.join("/build", "output", job_id)103 output_path = os.path.join("/build", "output", job_id)
104 self.backend.run(["mkdir", "-p", output_path])104 self.backend.run(["mkdir", "-p", output_path])
105 lpcraft_args = [105 lpcraft_args = [
106 "lpcraft", "-v", "run-one", "--output", output_path,106 "lpcraft", "-v", "run-one", "--output-directory", output_path,
107 self.args.job_name, str(self.args.job_index),107 self.args.job_name, str(self.args.job_index),
108 ]108 ]
109 tee_args = ["tee", "%s.log" % output_path]109 tee_args = ["tee", "%s.log" % output_path]
diff --git a/lpbuildd/target/tests/test_run_ci.py b/lpbuildd/target/tests/test_run_ci.py
index aad9e54..9c6621e 100644
--- a/lpbuildd/target/tests/test_run_ci.py
+++ b/lpbuildd/target/tests/test_run_ci.py
@@ -313,7 +313,7 @@ class TestRunCI(TestCase):
313 RanCommand(["mkdir", "-p", "/build/output/test:0"]),313 RanCommand(["mkdir", "-p", "/build/output/test:0"]),
314 RanBuildCommand([314 RanBuildCommand([
315 "/bin/bash", "-o", "pipefail", "-c",315 "/bin/bash", "-o", "pipefail", "-c",
316 "lpcraft -v run-one --output /build/output/test:0 test 0 2>&1 "316 "lpcraft -v run-one --output-directory /build/output/test:0 test 0 2>&1 " # noqa: E501
317 "| tee /build/output/test:0.log",317 "| tee /build/output/test:0.log",
318 ], cwd="/build/tree"),318 ], cwd="/build/tree"),
319 ]))319 ]))
@@ -337,7 +337,7 @@ class TestRunCI(TestCase):
337 RanCommand(["mkdir", "-p", "/build/output/test:0"]),337 RanCommand(["mkdir", "-p", "/build/output/test:0"]),
338 RanBuildCommand([338 RanBuildCommand([
339 "/bin/bash", "-o", "pipefail", "-c",339 "/bin/bash", "-o", "pipefail", "-c",
340 "lpcraft -v run-one --output /build/output/test:0 test 0 2>&1 "340 "lpcraft -v run-one --output-directory /build/output/test:0 test 0 2>&1 " # noqa: E501
341 "| tee /build/output/test:0.log",341 "| tee /build/output/test:0.log",
342 ], cwd="/build/tree", **env),342 ], cwd="/build/tree", **env),
343 ]))343 ]))

Subscribers

People subscribed via source and target branches