Code review comment for lp:~jtv/maas/zero-vlan-tag-is-not-unique

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks great, I especially like the thought put into the random tag in the factory func.

Can I persuade you to go and edit the old migration though please, having multiple migrations for the same new model is ugly, embarrassing and inefficient. It's not been released to trusty yet so it's fine.

review: Approve

« Back to merge proposal