Code review comment for lp:~jtv/maas/validate-network-nodes-filter

Revision history for this message
Raphaƫl Badin (rvb) wrote :

Very nice!

[0]

24 + if nodes is not None:
25 + for node in nodes:
26 networks = networks.filter(node=node)
27 return networks.order_by('name')

Ideally, I think this logic (the filtering and the order_by) belongs to the form (same as the usual call to form.save() when the form is a modification/creation form).

review: Approve

« Back to merge proposal