Code review comment for lp:~jtv/maas/test-multi-zonegenerator

Revision history for this message
Gavin Panella (allenap) wrote :

[1]

=== modified file 'src/maasserver/dns.py'
[...]

Everything in here is change for the sake of change. If you must, land
it, but I'm not sure there was any lack of clarity before, and there
certainly isn't any more now.

[2]

+class TestLazyDict(TestCase):

This is cool. Thanks for adding it; I was the one who didn't test it the
first time around. Same goes for ZoneGenerator, except for the top-level
tests.

[3]

+    def test_holds_one_value_per_key(self):

Not sure what this demonstrates. lazydict inherits from dict, so this
isn't surprising behaviour.

review: Approve

« Back to merge proposal