Code review comment for lp:~jtv/maas/show-commissioning-results
Revision history for this message
| Raphaël Badin (rvb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Couple of remarks about the listing page:
[4]
It would be nice to see, possibly in the title of the page, a mention of the node used to filter the results. (I know the node is part of the fields listed in the listing itself.)
[5]
It's weird having to click on the status to access the result page. It's weird because I'd expect having to click on the name of the file and it's weird because I'd expect the link to be on the left-hand side, like with all the other listings in MAAS.
Couple of remarks about the result page:
[6]
"Time" says "Result was registered at Feb. 17, 2014, 10:16 a.m.".
I'd get rid of the "Result was registered at" and put it in the title instead. I think it's best to keep the value of the fields to exactly what's in the database for clarity. The explanation of what the field is should be in the title.
Same remark for "Return value" (example value: "Script returned 2").