Code review comment for lp:~jtv/maas/pkg-import-as-maas

[0]

18 + # Set up a "GPG home directory" for the maas user. This is where
19 + # GnuPG can store its state when verifying import boot resources.
20 + # We can't set a permanent home directory for the maas user, because
21 + # the user may already have been created by an older version of maas;
22 + # usermod won't set a home directory for a user that has processes
23 + # running, as may be the case for maas.
24 + mkdir -p /var/lib/maas/gnupg
25 + chown $user:$user /var/lib/maas/gnupg

We want to keep the post-inst scripts as minimal as possible… coulnd't this be part of the MAAS source code?

[1]

> Maybe it should be in maas-cluster-controller instead of maas-common.

If we need to keep this in the packaging, I think it should be in maas-cluster-controller indeed. AFAIK this is really something that belongs to the clusters.

[2]

You need a changelog entry for this.