Code review comment for lp:~jtv/maas/import-to-tftp

> Compatibility with what? Windows? Python 3? Unusual encodings? Given that this is for ASCII text files written from
> the same tests, what's the benefit of treating them as binary files?

Yes, Windows. I guess it's a little bit stupid in this instance as you mention but nonetheless, it's probably a good habit.

> Remember: cleanup is a noun, clean up is a verb!

Rarg!

> I don't like to worry too much about these small things in advance: if cleanup fits in naturally with the other work,
> we'll just do it and not worry about it. If we discover that it doesn't, then that is a good time to file a bug
> or a card so we don't remember. Until then, piling up detailed bugs or cards will just cloud our view of the work
> ahead. And as always: no matter how clear-cut a remote problem seems now, expect our view of it to change by the
> time it becomes relevant.

Fair enough.