Code review comment for lp:~jtv/maas/import-from-configured-mirror

On Thursday 08 November 2012 16:07:29 you wrote:
> + config_parameters = {
> + 'http_proxy',
> + 'main_archive',
> + 'ports_archive',
> + 'cloud_images_archive',
> + }

How many places do we refer to these strings now? About time for some
encapsulation or at least a constant, as this is a recipe for disaster.

Especially when you start doing this in tests:

+ archives = {
+ 'main_archive': make_archive_url('main'),
+ 'ports_archive': make_archive_url('ports'),
+ 'cloud_images_archive': make_archive_url('cloud_images'),
+ }
+ for key, value in archives.items():
+ Config.objects.set_config(key, value)