Looks good, but you need more tests for the SQL changes, particularly all the scenarios around mixing v4/v6 and same/different MACs. I trust you will get those right since you're probably the best test writer on the team, which pains me to write this review :)
Looks good, but you need more tests for the SQL changes, particularly all the scenarios around mixing v4/v6 and same/different MACs. I trust you will get those right since you're probably the best test writer on the team, which pains me to write this review :)