Code review comment for lp:~jtv/maas/db-fixture

Revision history for this message
Gavin Panella (allenap) wrote :

> 1. Pass stdout=PIPE to check_call, which eats the routine output when
> running implicitly from bin/test.

This can deadlock when the pipe's buffer fills up. Instead stdout
could be redirected to a temporary file, or just to /dev/null:

  with open(os.devnull, "wb") as devnull:
      check_call([...], stdout=devnull)

> 2. Initialize the cluster with "-A trust" to suppress the warning
> about defaulting to trust authentication.

Cool :)

« Back to merge proposal