Merge lp:~jtv/maas/db-default-disable-ipv4 into lp:~maas-committers/maas/trunk

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 3041
Proposed branch: lp:~jtv/maas/db-default-disable-ipv4
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 455 lines (+395/-4)
3 files modified
src/maasserver/migrations/0111_add_nodegroup_default_disable_ipv4.py (+375/-0)
src/maasserver/models/nodegroup.py (+14/-2)
src/maasserver/testing/factory.py (+6/-2)
To merge this branch: bzr merge lp:~jtv/maas/db-default-disable-ipv4
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+235267@code.launchpad.net

Commit message

Add new field to schema: NodeGroup.default_disable_ipv4. Provides a default for Node.disable_ipv4.

Description of the change

Andres requested a default setting, to make it easier to set a common policy for a site's nodes. I think the cluster is the right place to put this: it gives slightly more control than setting it globally. You can have a dedicated IPv6-only cluster.

Nor does it make sense to set this on the cluster interface. One, the setting is for the entire node, not just one network interface. And two, it is inherently only useful for situations where a node has a single network interface connecting to two cluster interfaces — one IPv4 and one IPv6.

In the UI, this new setting will be hidden behind the REVEAL_IPv6 flag. It will be settable from the API, but not pushed in the user's face until we're ready. And right now of course, the setting doesn't actually do anything yet.

Jeroen

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'src/maasserver/migrations/0111_add_nodegroup_default_disable_ipv4.py'
--- src/maasserver/migrations/0111_add_nodegroup_default_disable_ipv4.py 1970-01-01 00:00:00 +0000
+++ src/maasserver/migrations/0111_add_nodegroup_default_disable_ipv4.py 2014-09-19 12:49:24 +0000
@@ -0,0 +1,375 @@
1from south.db import db
2from south.v2 import SchemaMigration
3
4
5class Migration(SchemaMigration):
6
7 def forwards(self, orm):
8 # Adding field 'NodeGroup.default_disable_ipv4'
9 db.add_column(u'maasserver_nodegroup', 'default_disable_ipv4',
10 self.gf('django.db.models.fields.BooleanField')(default=False),
11 keep_default=False)
12
13
14 def backwards(self, orm):
15 # Deleting field 'NodeGroup.default_disable_ipv4'
16 db.delete_column(u'maasserver_nodegroup', 'default_disable_ipv4')
17
18
19 models = {
20 u'auth.group': {
21 'Meta': {'object_name': 'Group'},
22 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
23 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '80'}),
24 'permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'})
25 },
26 u'auth.permission': {
27 'Meta': {'ordering': "(u'content_type__app_label', u'content_type__model', u'codename')", 'unique_together': "((u'content_type', u'codename'),)", 'object_name': 'Permission'},
28 'codename': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
29 'content_type': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['contenttypes.ContentType']"}),
30 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
31 'name': ('django.db.models.fields.CharField', [], {'max_length': '50'})
32 },
33 u'auth.user': {
34 'Meta': {'object_name': 'User'},
35 'date_joined': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
36 'email': ('django.db.models.fields.EmailField', [], {'unique': 'True', 'max_length': '75', 'blank': 'True'}),
37 'first_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
38 'groups': ('django.db.models.fields.related.ManyToManyField', [], {'symmetrical': 'False', 'related_name': "u'user_set'", 'blank': 'True', 'to': u"orm['auth.Group']"}),
39 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
40 'is_active': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
41 'is_staff': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
42 'is_superuser': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
43 'last_login': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
44 'last_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
45 'password': ('django.db.models.fields.CharField', [], {'max_length': '128'}),
46 'user_permissions': ('django.db.models.fields.related.ManyToManyField', [], {'symmetrical': 'False', 'related_name': "u'user_set'", 'blank': 'True', 'to': u"orm['auth.Permission']"}),
47 'username': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '30'})
48 },
49 u'contenttypes.contenttype': {
50 'Meta': {'ordering': "('name',)", 'unique_together': "(('app_label', 'model'),)", 'object_name': 'ContentType', 'db_table': "'django_content_type'"},
51 'app_label': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
52 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
53 'model': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
54 'name': ('django.db.models.fields.CharField', [], {'max_length': '100'})
55 },
56 u'maasserver.bootimage': {
57 'Meta': {'unique_together': "((u'nodegroup', u'osystem', u'architecture', u'subarchitecture', u'release', u'purpose', u'label'),)", 'object_name': 'BootImage'},
58 'architecture': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
59 'created': ('django.db.models.fields.DateTimeField', [], {}),
60 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
61 'label': ('django.db.models.fields.CharField', [], {'default': "u'release'", 'max_length': '255'}),
62 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}),
63 'osystem': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
64 'purpose': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
65 'release': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
66 'subarchitecture': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
67 'supported_subarches': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
68 'updated': ('django.db.models.fields.DateTimeField', [], {}),
69 'xinstall_path': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'null': 'True', 'blank': 'True'}),
70 'xinstall_type': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '30', 'null': 'True', 'blank': 'True'})
71 },
72 u'maasserver.bootresource': {
73 'Meta': {'unique_together': "((u'name', u'architecture'),)", 'object_name': 'BootResource'},
74 'architecture': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
75 'created': ('django.db.models.fields.DateTimeField', [], {}),
76 'extra': ('maasserver.fields.JSONObjectField', [], {'default': "u''", 'blank': 'True'}),
77 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
78 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
79 'rtype': ('django.db.models.fields.IntegerField', [], {'max_length': '10'}),
80 'updated': ('django.db.models.fields.DateTimeField', [], {})
81 },
82 u'maasserver.bootresourcefile': {
83 'Meta': {'unique_together': "((u'resource_set', u'filetype'),)", 'object_name': 'BootResourceFile'},
84 'created': ('django.db.models.fields.DateTimeField', [], {}),
85 'extra': ('maasserver.fields.JSONObjectField', [], {'default': "u''", 'blank': 'True'}),
86 'filename': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
87 'filetype': ('django.db.models.fields.CharField', [], {'default': "u'root-tgz'", 'max_length': '20'}),
88 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
89 'largefile': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.LargeFile']"}),
90 'resource_set': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "u'files'", 'to': u"orm['maasserver.BootResourceSet']"}),
91 'updated': ('django.db.models.fields.DateTimeField', [], {})
92 },
93 u'maasserver.bootresourceset': {
94 'Meta': {'unique_together': "((u'resource', u'version'),)", 'object_name': 'BootResourceSet'},
95 'created': ('django.db.models.fields.DateTimeField', [], {}),
96 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
97 'label': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
98 'resource': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "u'sets'", 'to': u"orm['maasserver.BootResource']"}),
99 'updated': ('django.db.models.fields.DateTimeField', [], {}),
100 'version': ('django.db.models.fields.CharField', [], {'max_length': '255'})
101 },
102 u'maasserver.bootsource': {
103 'Meta': {'object_name': 'BootSource'},
104 'created': ('django.db.models.fields.DateTimeField', [], {}),
105 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
106 'keyring_data': ('maasserver.fields.EditableBinaryField', [], {'blank': 'True'}),
107 'keyring_filename': ('django.db.models.fields.FilePathField', [], {'max_length': '100', 'blank': 'True'}),
108 'updated': ('django.db.models.fields.DateTimeField', [], {}),
109 'url': ('django.db.models.fields.URLField', [], {'unique': 'True', 'max_length': '200'})
110 },
111 u'maasserver.bootsourceselection': {
112 'Meta': {'object_name': 'BootSourceSelection'},
113 'arches': ('djorm_pgarray.fields.ArrayField', [], {'default': 'None', 'dbtype': "u'text'", 'null': 'True', 'blank': 'True'}),
114 'boot_source': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.BootSource']"}),
115 'created': ('django.db.models.fields.DateTimeField', [], {}),
116 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
117 'labels': ('djorm_pgarray.fields.ArrayField', [], {'default': 'None', 'dbtype': "u'text'", 'null': 'True', 'blank': 'True'}),
118 'os': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '20', 'blank': 'True'}),
119 'release': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '20', 'blank': 'True'}),
120 'subarches': ('djorm_pgarray.fields.ArrayField', [], {'default': 'None', 'dbtype': "u'text'", 'null': 'True', 'blank': 'True'}),
121 'updated': ('django.db.models.fields.DateTimeField', [], {})
122 },
123 u'maasserver.candidatename': {
124 'Meta': {'unique_together': "((u'name', u'position'),)", 'object_name': 'CandidateName'},
125 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
126 'name': ('django.db.models.fields.SlugField', [], {'max_length': '50'}),
127 'position': ('django.db.models.fields.IntegerField', [], {})
128 },
129 u'maasserver.componenterror': {
130 'Meta': {'object_name': 'ComponentError'},
131 'component': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '40'}),
132 'created': ('django.db.models.fields.DateTimeField', [], {}),
133 'error': ('django.db.models.fields.CharField', [], {'max_length': '1000'}),
134 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
135 'updated': ('django.db.models.fields.DateTimeField', [], {})
136 },
137 u'maasserver.config': {
138 'Meta': {'object_name': 'Config'},
139 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
140 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
141 'value': ('maasserver.fields.JSONObjectField', [], {'null': 'True'})
142 },
143 u'maasserver.dhcplease': {
144 'Meta': {'object_name': 'DHCPLease'},
145 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
146 'ip': ('maasserver.fields.MAASIPAddressField', [], {'unique': 'True', 'max_length': '39'}),
147 'mac': ('maasserver.fields.MACAddressField', [], {}),
148 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"})
149 },
150 u'maasserver.downloadprogress': {
151 'Meta': {'object_name': 'DownloadProgress'},
152 'bytes_downloaded': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
153 'created': ('django.db.models.fields.DateTimeField', [], {}),
154 'error': ('django.db.models.fields.CharField', [], {'max_length': '1000', 'blank': 'True'}),
155 'filename': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
156 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
157 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}),
158 'size': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
159 'updated': ('django.db.models.fields.DateTimeField', [], {})
160 },
161 u'maasserver.event': {
162 'Meta': {'object_name': 'Event'},
163 'created': ('django.db.models.fields.DateTimeField', [], {}),
164 'description': ('django.db.models.fields.TextField', [], {'default': "u''", 'blank': 'True'}),
165 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
166 'node': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.Node']"}),
167 'type': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.EventType']"}),
168 'updated': ('django.db.models.fields.DateTimeField', [], {})
169 },
170 u'maasserver.eventtype': {
171 'Meta': {'object_name': 'EventType'},
172 'created': ('django.db.models.fields.DateTimeField', [], {}),
173 'description': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
174 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
175 'level': ('django.db.models.fields.IntegerField', [], {}),
176 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '255'}),
177 'updated': ('django.db.models.fields.DateTimeField', [], {})
178 },
179 u'maasserver.filestorage': {
180 'Meta': {'unique_together': "((u'filename', u'owner'),)", 'object_name': 'FileStorage'},
181 'content': ('metadataserver.fields.BinaryField', [], {'blank': 'True'}),
182 'filename': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
183 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
184 'key': ('django.db.models.fields.CharField', [], {'default': "u'151cf944-3fe8-11e4-abeb-94de80b61466'", 'unique': 'True', 'max_length': '36'}),
185 'owner': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['auth.User']", 'null': 'True', 'blank': 'True'})
186 },
187 u'maasserver.largefile': {
188 'Meta': {'object_name': 'LargeFile'},
189 'content': ('maasserver.fields.LargeObjectField', [], {}),
190 'created': ('django.db.models.fields.DateTimeField', [], {}),
191 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
192 'sha256': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '64'}),
193 'total_size': ('django.db.models.fields.BigIntegerField', [], {}),
194 'updated': ('django.db.models.fields.DateTimeField', [], {})
195 },
196 u'maasserver.licensekey': {
197 'Meta': {'unique_together': "((u'osystem', u'distro_series'),)", 'object_name': 'LicenseKey'},
198 'created': ('django.db.models.fields.DateTimeField', [], {}),
199 'distro_series': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
200 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
201 'license_key': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
202 'osystem': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
203 'updated': ('django.db.models.fields.DateTimeField', [], {})
204 },
205 u'maasserver.macaddress': {
206 'Meta': {'ordering': "(u'created',)", 'object_name': 'MACAddress'},
207 'cluster_interface': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['maasserver.NodeGroupInterface']", 'null': 'True', 'blank': 'True'}),
208 'created': ('django.db.models.fields.DateTimeField', [], {}),
209 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
210 'ip_addresses': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['maasserver.StaticIPAddress']", 'symmetrical': 'False', 'through': u"orm['maasserver.MACStaticIPAddressLink']", 'blank': 'True'}),
211 'mac_address': ('maasserver.fields.MACAddressField', [], {'unique': 'True'}),
212 'networks': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['maasserver.Network']", 'symmetrical': 'False', 'blank': 'True'}),
213 'node': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.Node']"}),
214 'updated': ('django.db.models.fields.DateTimeField', [], {})
215 },
216 u'maasserver.macstaticipaddresslink': {
217 'Meta': {'unique_together': "((u'ip_address', u'mac_address'),)", 'object_name': 'MACStaticIPAddressLink'},
218 'created': ('django.db.models.fields.DateTimeField', [], {}),
219 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
220 'ip_address': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.StaticIPAddress']", 'unique': 'True'}),
221 'mac_address': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.MACAddress']"}),
222 'nic_alias': ('django.db.models.fields.IntegerField', [], {'default': 'None', 'null': 'True', 'blank': 'True'}),
223 'updated': ('django.db.models.fields.DateTimeField', [], {})
224 },
225 u'maasserver.network': {
226 'Meta': {'object_name': 'Network'},
227 'default_gateway': ('maasserver.fields.MAASIPAddressField', [], {'max_length': '39', 'null': 'True', 'blank': 'True'}),
228 'description': ('django.db.models.fields.TextField', [], {'blank': 'True'}),
229 'dns_servers': ('django.db.models.fields.CharField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}),
230 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
231 'ip': ('maasserver.fields.MAASIPAddressField', [], {'unique': 'True', 'max_length': '39'}),
232 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '255'}),
233 'netmask': ('maasserver.fields.MAASIPAddressField', [], {'max_length': '39'}),
234 'vlan_tag': ('django.db.models.fields.PositiveSmallIntegerField', [], {'unique': 'True', 'null': 'True', 'blank': 'True'})
235 },
236 u'maasserver.node': {
237 'Meta': {'object_name': 'Node'},
238 'agent_name': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'null': 'True', 'blank': 'True'}),
239 'architecture': ('django.db.models.fields.CharField', [], {'max_length': '31'}),
240 'boot_type': ('django.db.models.fields.CharField', [], {'default': "u'fastpath'", 'max_length': '20'}),
241 'cpu_count': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
242 'created': ('django.db.models.fields.DateTimeField', [], {}),
243 'disable_ipv4': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
244 'distro_series': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '20', 'blank': 'True'}),
245 'error': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}),
246 'error_description': ('django.db.models.fields.TextField', [], {'default': "u''", 'blank': 'True'}),
247 'hostname': ('django.db.models.fields.CharField', [], {'default': "u''", 'unique': 'True', 'max_length': '255', 'blank': 'True'}),
248 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
249 'license_key': ('django.db.models.fields.CharField', [], {'max_length': '30', 'null': 'True', 'blank': 'True'}),
250 'memory': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
251 'netboot': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
252 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']", 'null': 'True'}),
253 'osystem': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '20', 'blank': 'True'}),
254 'owner': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['auth.User']", 'null': 'True', 'blank': 'True'}),
255 'power_parameters': ('maasserver.fields.JSONObjectField', [], {'default': "u''", 'blank': 'True'}),
256 'power_state': ('django.db.models.fields.CharField', [], {'default': "u'unknown'", 'max_length': '10'}),
257 'power_type': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '10', 'blank': 'True'}),
258 'routers': ('djorm_pgarray.fields.ArrayField', [], {'default': 'None', 'dbtype': "u'macaddr'", 'null': 'True', 'blank': 'True'}),
259 'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '10'}),
260 'storage': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
261 'system_id': ('django.db.models.fields.CharField', [], {'default': "u'node-151ba76a-3fe8-11e4-abeb-94de80b61466'", 'unique': 'True', 'max_length': '41'}),
262 'tags': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['maasserver.Tag']", 'symmetrical': 'False'}),
263 'token': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Token']", 'null': 'True'}),
264 'updated': ('django.db.models.fields.DateTimeField', [], {}),
265 'zone': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.Zone']", 'on_delete': 'models.SET_DEFAULT'})
266 },
267 u'maasserver.nodegroup': {
268 'Meta': {'object_name': 'NodeGroup'},
269 'api_key': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '18'}),
270 'api_token': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Token']", 'unique': 'True'}),
271 'cluster_name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '100', 'blank': 'True'}),
272 'created': ('django.db.models.fields.DateTimeField', [], {}),
273 'default_disable_ipv4': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
274 'dhcp_key': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}),
275 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
276 'maas_url': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}),
277 'name': ('django.db.models.fields.CharField', [], {'max_length': '80', 'blank': 'True'}),
278 'status': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
279 'updated': ('django.db.models.fields.DateTimeField', [], {}),
280 'uuid': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '36'})
281 },
282 u'maasserver.nodegroupinterface': {
283 'Meta': {'unique_together': "((u'nodegroup', u'name'),)", 'object_name': 'NodeGroupInterface'},
284 'broadcast_ip': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
285 'created': ('django.db.models.fields.DateTimeField', [], {}),
286 'foreign_dhcp_ip': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
287 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
288 'interface': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}),
289 'ip': ('maasserver.fields.MAASIPAddressField', [], {'max_length': '39'}),
290 'ip_range_high': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
291 'ip_range_low': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
292 'management': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
293 'name': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}),
294 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}),
295 'router_ip': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
296 'static_ip_range_high': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
297 'static_ip_range_low': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
298 'subnet_mask': ('maasserver.fields.MAASIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}),
299 'updated': ('django.db.models.fields.DateTimeField', [], {})
300 },
301 u'maasserver.sshkey': {
302 'Meta': {'unique_together': "((u'user', u'key'),)", 'object_name': 'SSHKey'},
303 'created': ('django.db.models.fields.DateTimeField', [], {}),
304 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
305 'key': ('django.db.models.fields.TextField', [], {}),
306 'updated': ('django.db.models.fields.DateTimeField', [], {}),
307 'user': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['auth.User']"})
308 },
309 u'maasserver.sslkey': {
310 'Meta': {'unique_together': "((u'user', u'key'),)", 'object_name': 'SSLKey'},
311 'created': ('django.db.models.fields.DateTimeField', [], {}),
312 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
313 'key': ('django.db.models.fields.TextField', [], {}),
314 'updated': ('django.db.models.fields.DateTimeField', [], {}),
315 'user': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['auth.User']"})
316 },
317 u'maasserver.staticipaddress': {
318 'Meta': {'object_name': 'StaticIPAddress'},
319 'alloc_type': ('django.db.models.fields.IntegerField', [], {'default': '0'}),
320 'created': ('django.db.models.fields.DateTimeField', [], {}),
321 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
322 'ip': ('maasserver.fields.MAASIPAddressField', [], {'unique': 'True', 'max_length': '39'}),
323 'updated': ('django.db.models.fields.DateTimeField', [], {}),
324 'user': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['auth.User']", 'null': 'True', 'blank': 'True'})
325 },
326 u'maasserver.tag': {
327 'Meta': {'object_name': 'Tag'},
328 'comment': ('django.db.models.fields.TextField', [], {'blank': 'True'}),
329 'created': ('django.db.models.fields.DateTimeField', [], {}),
330 'definition': ('django.db.models.fields.TextField', [], {'blank': 'True'}),
331 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
332 'kernel_opts': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}),
333 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '256'}),
334 'updated': ('django.db.models.fields.DateTimeField', [], {})
335 },
336 u'maasserver.userprofile': {
337 'Meta': {'object_name': 'UserProfile'},
338 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
339 'user': ('django.db.models.fields.related.OneToOneField', [], {'to': u"orm['auth.User']", 'unique': 'True'})
340 },
341 u'maasserver.zone': {
342 'Meta': {'ordering': "[u'name']", 'object_name': 'Zone'},
343 'created': ('django.db.models.fields.DateTimeField', [], {}),
344 'description': ('django.db.models.fields.TextField', [], {'blank': 'True'}),
345 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
346 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '256'}),
347 'updated': ('django.db.models.fields.DateTimeField', [], {})
348 },
349 u'piston.consumer': {
350 'Meta': {'object_name': 'Consumer'},
351 'description': ('django.db.models.fields.TextField', [], {}),
352 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
353 'key': ('django.db.models.fields.CharField', [], {'max_length': '18'}),
354 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
355 'secret': ('django.db.models.fields.CharField', [], {'max_length': '32'}),
356 'status': ('django.db.models.fields.CharField', [], {'default': "'pending'", 'max_length': '16'}),
357 'user': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'consumers'", 'null': 'True', 'to': u"orm['auth.User']"})
358 },
359 u'piston.token': {
360 'Meta': {'object_name': 'Token'},
361 'callback': ('django.db.models.fields.CharField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}),
362 'callback_confirmed': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
363 'consumer': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Consumer']"}),
364 u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
365 'is_approved': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
366 'key': ('django.db.models.fields.CharField', [], {'max_length': '18'}),
367 'secret': ('django.db.models.fields.CharField', [], {'max_length': '32'}),
368 'timestamp': ('django.db.models.fields.IntegerField', [], {'default': '1411122674L'}),
369 'token_type': ('django.db.models.fields.IntegerField', [], {}),
370 'user': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'tokens'", 'null': 'True', 'to': u"orm['auth.User']"}),
371 'verifier': ('django.db.models.fields.CharField', [], {'max_length': '10'})
372 }
373 }
374
375 complete_apps = ['maasserver']
0376
=== modified file 'src/maasserver/models/nodegroup.py'
--- src/maasserver/models/nodegroup.py 2014-09-17 20:36:17 +0000
+++ src/maasserver/models/nodegroup.py 2014-09-19 12:49:24 +0000
@@ -20,6 +20,7 @@
2020
21from apiclient.creds import convert_tuple_to_string21from apiclient.creds import convert_tuple_to_string
22from django.db.models import (22from django.db.models import (
23 BooleanField,
23 CharField,24 CharField,
24 ForeignKey,25 ForeignKey,
25 IntegerField,26 IntegerField,
@@ -58,7 +59,8 @@
58 """59 """
5960
60 def new(self, name, uuid, subnet_mask=None, dhcp_key='',61 def new(self, name, uuid, subnet_mask=None, dhcp_key='',
61 status=NODEGROUP_STATUS.DEFAULT, cluster_name=None, maas_url=''):62 status=NODEGROUP_STATUS.DEFAULT, cluster_name=None, maas_url='',
63 default_disable_ipv4=False):
62 """Create a :class:`NodeGroup` with the given parameters.64 """Create a :class:`NodeGroup` with the given parameters.
6365
64 Also generates API credentials for the nodegroup's worker to use.66 Also generates API credentials for the nodegroup's worker to use.
@@ -67,7 +69,8 @@
67 cluster_name = NODEGROUP_CLUSTER_NAME_TEMPLATE % {'uuid': uuid}69 cluster_name = NODEGROUP_CLUSTER_NAME_TEMPLATE % {'uuid': uuid}
68 nodegroup = NodeGroup(70 nodegroup = NodeGroup(
69 name=name, uuid=uuid, cluster_name=cluster_name, dhcp_key=dhcp_key,71 name=name, uuid=uuid, cluster_name=cluster_name, dhcp_key=dhcp_key,
70 status=status, maas_url=maas_url)72 status=status, maas_url=maas_url,
73 default_disable_ipv4=default_disable_ipv4)
71 nodegroup.save()74 nodegroup.save()
72 return nodegroup75 return nodegroup
7376
@@ -173,6 +176,15 @@
173 maas_url = CharField(176 maas_url = CharField(
174 blank=True, editable=False, max_length=255, default='')177 blank=True, editable=False, max_length=255, default='')
175178
179 # Should nodes on this cluster be configured to disable IPv4 on deployment
180 # by default?
181 default_disable_ipv4 = BooleanField(
182 default=False,
183 verbose_name="Disable IPv4 by default when deploying nodes",
184 help_text=(
185 "Default setting for setting on new nodes: disable IPv4 when "
186 "deploying, on operating systems where this is supported."))
187
176 @property188 @property
177 def api_credentials(self):189 def api_credentials(self):
178 """Return a string containing credentials for this nodegroup."""190 """Return a string containing credentials for this nodegroup."""
179191
=== modified file 'src/maasserver/testing/factory.py'
--- src/maasserver/testing/factory.py 2014-09-19 04:46:35 +0000
+++ src/maasserver/testing/factory.py 2014-09-19 12:49:24 +0000
@@ -351,7 +351,8 @@
351 subnet_mask=None, broadcast_ip=None, ip_range_low=None,351 subnet_mask=None, broadcast_ip=None, ip_range_low=None,
352 ip_range_high=None, interface=None, management=None,352 ip_range_high=None, interface=None, management=None,
353 status=None, maas_url='', static_ip_range_low=None,353 status=None, maas_url='', static_ip_range_low=None,
354 static_ip_range_high=None, **kwargs):354 static_ip_range_high=None, default_disable_ipv4=None,
355 **kwargs):
355 """Create a :class:`NodeGroup`.356 """Create a :class:`NodeGroup`.
356357
357 If `management` is set (to a `NODEGROUPINTERFACE_MANAGEMENT` value),358 If `management` is set (to a `NODEGROUPINTERFACE_MANAGEMENT` value),
@@ -373,9 +374,12 @@
373 if dhcp_key is None:374 if dhcp_key is None:
374 # TODO: Randomise this properly.375 # TODO: Randomise this properly.
375 dhcp_key = ''376 dhcp_key = ''
377 if default_disable_ipv4 is None:
378 default_disable_ipv4 = factory.pick_bool()
376 cluster = NodeGroup.objects.new(379 cluster = NodeGroup.objects.new(
377 name=name, uuid=uuid, cluster_name=cluster_name, status=status,380 name=name, uuid=uuid, cluster_name=cluster_name, status=status,
378 dhcp_key=dhcp_key, maas_url=maas_url)381 dhcp_key=dhcp_key, maas_url=maas_url,
382 default_disable_ipv4=default_disable_ipv4)
379 if management is not None:383 if management is not None:
380 interface_settings = dict(384 interface_settings = dict(
381 ip=ip, router_ip=router_ip, network=network,385 ip=ip, router_ip=router_ip, network=network,