Code review comment for lp:~jtv/maas/custom-dhcp

Revision history for this message
John A Meinel (jameinel) wrote :

Would it make sense to gather up all the files that need to be written under sudo and do them with one call rather than several? Do we get a decent error message up to users if sudo fails because of '-n' (or just a stacktrace in python because the command failed?)

Otherwise looks fine to me.

review: Approve

« Back to merge proposal