Code review comment for lp:~jtv/maas/bug-1058313

Revision history for this message
John A Meinel (jameinel) wrote :

Are there any times other than during enlistment where public-keys are requested and it would be better to put something in the log?
if
22 + if item == 'public-keys':
23 + return HttpResponseNotFound("No SSH keys available for this node.")

is only in the 'enlistment' codepath, then it seems perfectly reasonable. And I certainly agree that not logging errors when there aren't any is a good thing.

review: Approve

« Back to merge proposal