> + production, unless you are confident that you can eavesdroppers from
Missing "prevent" ... ?
46 + if is_admin: 47 + User.objects.create_superuser( 48 + username=username, password=password, email=email) 49 + else: 50 + User.objects.create_user( 51 + username=username, password=password, email=email) 52 + return rc.ALL_OK
Do the create_* methods always succeed? Surely this needs some error checking? Or do they raise an exception?
Everything else looks great.
« Back to merge proposal
> + production, unless you are confident that you can eavesdroppers from
Missing "prevent" ... ?
46 + if is_admin: create_ superuser( create_ user(
47 + User.objects.
48 + username=username, password=password, email=email)
49 + else:
50 + User.objects.
51 + username=username, password=password, email=email)
52 + return rc.ALL_OK
Do the create_* methods always succeed? Surely this needs some error checking? Or do they raise an exception?
Everything else looks great.