Code review comment for lp:~jtv/lazr-js/bug-427263-3
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
= Bug 427263 =
This is a bug that's been bothering us for far too long. The inline editor's edit button doesn't always show up on Konqueror.
It used not to show up in Konqueror at all. In a previous attempt at a fix, I set an empty "content" attribute for the button's :link and :visited pseudo-classes. The browser should ignore these, but Konqueror doesn't. It didn't matter that the content string was empty, even if Konqueror actually obeyed that attribute, since text-wise the button really is empty. We're using a sprite so it's the background that matters.
What _did_ matter is that Konqueror still doesn't seem to render the button in some cases if the content string is empty. So I made it non-empty. It now contains a zero-width, minimally-invasive Unicode character. Other browsers will ignore it; but even in Konqueror it looks good now.
Tested with Arora 0.10.1; Chromium 5.0.320.0; Epiphany 2.28.0; Firefox 3.5.7; Galeon 2.0.7; and Konqueror 4.3.2.
Jeroen