Code review comment for lp:~jtv/lazr-js/bug-427263-2

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> = Bug 427263, 2nd attempt =
>

[snip]

> This new fix is pure CSS. Turns out Konqueror does render the <a> tag if I
> apply an empty content attribute to its :link and :visited pseudoclasses.

Nice!

>
> As far as I can tell, the content attribute is ignored in these pseudoclasses:
> http://www.w3schools.com/CSS/pr_gen_content.asp (and a quick check in Firefox
> concurs).

Changing the css to content: "randomtext" seems to show that it's *not* ignored in konqueror (at least, not on 4.3 on my machine here), but it works perfectly with the empty content.

>
> If some browser should fail to ignore it, and either it lets the content
> attribute override the tag's dimensions or we want something else than a
> sprite in the tag, then we may have to go looking for a new trick. I tested
> in Arora, Chromium, Firefox, Galeon, and Konqueror; most Internet Explorer
> versions apparently don't support the content attribute in the first place, so
> it's not likely to cause problems there either.

It would be worth checking this in IE8 (which apparently does support content when a valid DOCTYPE is set?).

Great find Jeroen!

>
>
> Jeroen

review: Approve (code)

« Back to merge proposal