Launchpad itself

Code review comment for lp:~jtv/launchpad/scale-message-sharing-migration

Revision history for this message

Brad Crittenden (bac) wrote on 2009-10-27:

Hi Jeroen,

Thanks for this branch. Other than the following issues this branch looks great.

* As discussed on IRC, the parser option around 67 needs an action and a better help description to remove the ambiguous 'some'.

* Remove the assignment at line 158.

* The comment at line 291 makes no sense as written.

review: Approve (code)