Code review comment for lp:~jtv/launchpad/pre-832647

189 + def _composeActiveSourcePubsCondition(self, distroseries, pocket):

It seems slightly odd to have this take distroseries and pocket, but grab archive from self. This is a common problem in Soyuz, since archives didn't exist when most of it was written. Something to think about, maybe.

234 + And(join_spr_spn(), join_spph_spr(), spph_location_clauses),

This would possibly be clearer if the order of arguments was reversed. The (SPR, SPN) -> (SPPH, SPR) -> SPPH chaining takes a while to pick up here.

319 + def listCreaitonDates(self, spphs):

Unused and misspelled :(