Code review comment for lp:~jtv/launchpad/bug-876348

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

From IRC (times in UTC):

(13:36:37) bigjools: jtv: actually EarlyReturn is not ideal thinking about it
(13:36:37) bigjools: we just need to add a rejection and let processing continue so it collects all the errors
(13:37:19) bigjools: I really detest the upload processor
(13:47:51) jtv: bigjools: I guess it's two problems: one, “malformed email address and policy that says to create the user” does something very different from “unknown email address and policy that says not to create the user” or “malformed email address and policy that says not to create the user.” Two, it'd be nice to have more robust handling of these error conditions.
(13:47:59) jtv: Does that make sense?

« Back to merge proposal