Merge lp:~jtv/launchpad/bug-806946 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Stuart Bishop | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13417 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-806946 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
189 lines (+71/-14) 7 files modified
lib/lp/registry/browser/distroseries.py (+1/-1) lib/lp/registry/interfaces/distroseriesdifference.py (+5/-4) lib/lp/registry/model/distroseries.py (+1/-1) lib/lp/registry/model/distroseriesdifference.py (+20/-5) lib/lp/registry/tests/test_distroseriesdifference.py (+41/-0) lib/lp/soyuz/interfaces/packageset.py (+2/-1) lib/lp/soyuz/model/packagecopyjob.py (+1/-2) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-806946 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+67302@code.launchpad.net |
Commit message
[r=stub][bug=806946] Packageset name search on +localpackagediffs.
Description of the change
= Summary =
There's a package-name search box on +localpackagediffs. When the name matches that of a packageset for the context distroseries, we want the page to show packages from that packageset.
== Proposed fix ==
This is a model change only. The UI and the web-service API may also need updating once we know that this performs well enough.
== Pre-implementation notes ==
It was wisely decided to honour only exact matches on packageset names. Ordering of results should not be affected.
== Implementation details ==
I did not widen the main search join, because it may affect ordering and uniqueness to a painful extent. Instead there's a one-off sub-query that I hope the query optimizer will execute separately, and quickly.
There was a weird failure on the JavaScript test test_distroseri
== Tests ==
{{{
./bin/test -vvc lp.registry.
}}}
== Demo and Q/A ==
Go to https:/
Pay particular attention to performance. There probably won't be any noticeable effect if the name you enter is not a packageset name, but when it is, performance needs watching.
= Launchpad lint =
There's one bit of pre-existing lint where somebody else's branch had a problem. Rather than touching it myself, I notified the author and it's being fixed.
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
487: W291 trailing whitespace
All good.