Launchpad itself

Code review comment for lp:~jtv/launchpad/bug-733245

  1. bug-733245
  2. Merge into devel
Revision history for this message
Benji York (benji) wrote :

Looks good.

Line 206 of lib/lp/registry/scripts/populate_distroseriesdiff.py (line
49 of the diff): I think you want to wrap temp_table in a call to
quote_identifier.

The use of the expression "3 - 1" in test_cutChunk_one_cuts_exactly_one
is creative and increases the clarity of the test.

review: Approve (code)

« Back to merge proposal