Code review comment for lp:~jtv/launchpad/bug-664327

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good, +1

[1]

+ @operation_parameters(
+ import_status=Choice(
+ title=_("Status"),
+ description=_("Show only entries with this status"),
+ values=RosettaImportStatus.items,
+ required=False),

I think you can use vocabulary=RosettaImportStatus instead of values.

[2]

+ >>> print target_queue['entries'][0]['path']
+ matching-entry.pot

Unless it's done elsewhere, it would be nice to document what is
returned by this method, rather than just a the path property of the
first entry.

review: Approve (code)

« Back to merge proposal