Merge lp:~jtv/launchpad/bug-594220 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11568 |
Proposed branch: | lp:~jtv/launchpad/bug-594220 |
Merge into: | lp:launchpad |
Diff against target: |
143 lines (+54/-20) 2 files modified
lib/lp/translations/scripts/po_import.py (+11/-3) lib/lp/translations/scripts/tests/test_translations_import.py (+43/-17) |
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-594220 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+35770@code.launchpad.net |
Commit message
Stop notifying vcs-imports about import of generated translation templates.
Description of the change
= Bug 594220 =
Translations uploads can enter the queue in several ways:
* Soyuz can upload ones generated during package build.
* Users can upload files.
* We can import them from bzr branches.
* The build farm can generate templates every time a branch changes.
In that last avenue, the resulting entries on the translations import queue are owned by whoever owns the branch. But what if the branch is mirrored? In that case, there is no reliably identifiable owner in Launchpad and such branches are owned by the vcs-imports celebrity.
Each of these imports normally results in an email message (either a success confirmation or a failure notice). And thus, vcs-imports got inundated with email when we implemented the generate-
We discussed alternatives, including sending the notifications to some other party, but we don't want to dump excessive email messages onto unsuspecting users. If there are problems with the imports that the emails would warn about, the import-queue UI will provide the same diagnostic information.
To test:
{{{
./bin/test -vvc lp.translations
}}}
For Q/A, we can verify that:
* templates generated from mirrored branches still hit the import queue,
* notification emails are still sent out, and
* vcs-imports stops receiving emails.
What with email filtering on staging, the surest way to verify that last point is to inquire after rollout. We should do that in addition to pre-rollout Q/A.
No lint,
Jeroen