Code review comment for lp:~jtv/launchpad/bug-427263

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

= Bug 427263 =

In Konqueror, the little "edit" buttons for bug descriptions and other multi-line edit fields do not show up. The reason, as Michael Nelson found, was that this browser does not render <a> tags with no text in them.

This branch works around that by inserting a zero-width non-joiner (as well as the sprite) in the anchor tag for the button. There are no visible changes in other browsers that I can see; as the name says, it's a zero-width character.

Tests:
{{{
./bin/test -t lazr-js-widgets.txt
}}}

Unsurprisingly, there's not a whole lot of test impact. This is purely a visual thing.

Demo and Q/A: Log in. Visit anything with an editable description that would normally use the Ajax inline editor—such a bug or a blueprint that you have edit rights on. (On a blueprint the "edit" icon will appear for the Whiteboard). Visit the same page in Konqueror, while logged into the same account. Without this fix, the edit icon is not visible. With this fix, it is. The inline editor doesn't work in konqueror, so it'll still take you to the pre-ajax edit form. But at least you've got a way to reach it!

Jeroen

« Back to merge proposal