Code review comment for lp:~jtv/launchpad/bug-423705

= Bug 423705: 3.0 Person Translations page =

This branch converts the Person page in Translations to the 3.0 style.
It also transforms the translation activity (previously "history")
listing on that page into something more like what we drew up in Buenos
Aires (minus the squiggles where the straight lines were supposed to be
:-)

The activity listing no longer floods the page with your complete
translation history; the full list has moved to a new "activity" page.
The person page now only shows the latest 10 entries.

What you see on the new page is a bit more detailed than the short list,
but also less detailed than what the existing Person page shows. The
reason is that it originally had a mixed bag of purposes, including
helping people reach the translations they've been working on. But for
that we now have the "translations you need to review" and "translations
you can help complete" listings.

I tried to get a two-column layout working for this page, but couldn't
because the elements on the page are much too variable. Each of the
portlets is conditional, all with different conditions. No static
layout is going to make that work well for even a reasonable number of
cases.

== Test ==

Best to run all Translations stories, as I did, but in particular:
{{{
./bin/test -vv -t xx-person-activity
}}}

== Demo and Q/A ==

For a nicely filled example, go to Carlos' home page:

    https://translations.launchpad.dev/~carlos

It gets better if you look at the same page but logged in as Carlos
(<email address hidden> / test).

From there, click on the "See all" link on the right, at the bottom of
the activity list. That takes you to the new, batched full activity
listing.

Also look at an empty page:

    https://translations.launchpad.dev/~salgado

And finally, there's the warning if you haven't set your preferred
languages. Log in as Brad (<email address hidden> / test) and visit Brad's
Translations page:

    https://translations.launchpad.dev/~bac

The "Please set them now" link will take you to the settings page where
you can select preferred languages.

== Lint ==
{{{
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/canonical/launchpad/webapp/configure.zcml
  lib/canonical/launchpad/webapp/tales.py
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/person.py
  lib/lp/translations/stories/standalone/xx-person-activity.txt
  lib/lp/translations/templates/person-navlinks.pt
  lib/lp/translations/templates/person-translation-activity.pt
  lib/lp/translations/templates/person-translations-to-complete-table.pt
  lib/lp/translations/templates/person-translations-to-review-table.pt
  lib/lp/translations/templates/person-translations.pt

=== Pylint notices ===

lib/canonical/launchpad/webapp/tales.py
    21: [F0401] Unable to import 'lazr.enum' (No module named enum)
}}}

I'm not planning to do anything about that last one.

Jeroen