Code review comment for lp:~jtv/gwacl/storage-urls

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Okay, I removed interpolateURL and that simplified a few things (like over-interpolation bugs we had to watch out for). I also whittled down the redundancy in the get*URL() tests. The branch now removes about as many lines as it adds. Since I'm more or less manning the fort alone this week, I'm going to land this and then we can argue over any remaining details later.

« Back to merge proposal