Code review comment for lp:~jtv/gwacl/name-factory

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Friday 05 Jul 2013 13:15:33 you wrote:
> 79 +// Be sure your random generator is initialized, or this will
> always produce 80 +// the same sequence!
>
> Why don't we initialize the generator in names.go? This is, I think, so
> easily forgotten that it's worth not letting that up to the caller.

Why not move all of this into helpers_factory_test.go where it really belongs,
which already has *Random* stuff in it and a corresponding init() to
initialise the generator?

« Back to merge proposal