Code review comment for lp:~jtv/gwacl/machine-types
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
On Friday 19 Jul 2013 06:51:27 you wrote:
> > 59 + CPUCores: 0,
> >
> > Not that it matters any more, but this is wrong, it's one core.
>
> See the comment in the line above, and the comment for the CPUCores field in
> the struct definition.
In the comment it says one :)
I still don't think a zero value is at all valid, you can't have no cpu cores.
The fact that it's shared is a separate property that I thought we'd said we
weren't going to model.