Code review comment for lp:~jtv/gwacl/factor-storage-requests

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good.

[1]

+func (params *requestParams) Check() {

This isn't used anywhere.

[2]

+func (context *StorageContext) performRequest(params requestParams) ...

So, does this mean that a copy of requestParams gets passed in? Does
that mean that copies of params' fields are made too? Body is an
io.Reader, so does that mean it's always a pointer/reference type, and
so only the pointer is copied? Same with Deserializer.

[3]

Is it worth keeping send() distinct from performRequest()?

review: Approve

« Back to merge proposal