Code review comment for lp:~jtv/gomaasapi/single-wrapper-class

Revision history for this message
Raphaël Badin (rvb) wrote :

> The %T prints the value's type, not its contents. The code is asymmetric, in that I'm printing a value (%v) for the
> wanted type but a type (%T) for the actual type; but that's because the parameters are respectively a string
> containing the requested type, and an example of the actual type. So the message that comes out will be symmetric:
> "Requested bool, got string."

Ah right, I missed that, thanks for the clarification.

> Not a typo. Typography. LaTeX, which is a great school for these things, taught me to move a full stop or comma
> inside the quotes. I do sometimes break that rule when talking about code or other literal strings where it may
> lead to confusion.

> I realize this may be controversial. It's been a while since I last read 1984, but as I recall Winston Smith, after
> the régime breaks him, gets put on a committee to argue this very point. That book was written about 65 years ago,
> so I'm fairly confident without looking that there has been no sudden consensus since that overrules the LaTeX
> rule. :-)

Hum, I did not know about that… and last time I used LaTeX is was less that 3 years ago… I must say this really looks ugly, I'll need to verify this…

> Speaking of controversial commas: I first read this as “There is a tiny problem in example/live_example.go now,
> with this fix. It works again”! That's the problem with using commas to separate sentences: it leaves room for
> ambiguity.

Yeah, sorry for the vague sentence.

« Back to merge proposal