Merge lp:~jtaylor/ubuntu/oneiric/ncbi-blast+/fix-803185 into lp:ubuntu/oneiric/ncbi-blast+

Proposed by Julian Taylor
Status: Merged
Merged at revision: 5
Proposed branch: lp:~jtaylor/ubuntu/oneiric/ncbi-blast+/fix-803185
Merge into: lp:ubuntu/oneiric/ncbi-blast+
Diff against target: 31 lines (+13/-0)
2 files modified
debian/changelog (+8/-0)
debian/rules (+5/-0)
To merge this branch: bzr merge lp:~jtaylor/ubuntu/oneiric/ncbi-blast+/fix-803185
Reviewer Review Type Date Requested Status
Kees Cook Approve
Review via email: mp+68268@code.launchpad.net

Description of the change

instead of fixing the underlinking most of the 60+ private libs of this package its simpler to just build the package without --as-needed
this fixes the build failure in bug 803185

To post a comment you must log in.
Revision history for this message
Kees Cook (kees) wrote :

Seems reasonable. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-09 19:25:45 +0000
3+++ debian/changelog 2011-07-18 15:34:39 +0000
4@@ -1,3 +1,11 @@
5+ncbi-blast+ (2.2.25-3ubuntu1) oneiric; urgency=low
6+
7+ * debian/rules: disable --as-needed build (LP: #803185)
8+ almost all private libs are underlinked, fixing them is not worth the
9+ effort
10+
11+ -- Julian Taylor <jtaylor.debian@googlemail.com> Mon, 18 Jul 2011 16:02:34 +0200
12+
13 ncbi-blast+ (2.2.25-3) unstable; urgency=low
14
15 * Team upload.
16
17=== modified file 'debian/rules'
18--- debian/rules 2011-06-09 19:25:45 +0000
19+++ debian/rules 2011-07-18 15:34:39 +0000
20@@ -24,6 +24,11 @@
21
22 export MAKE
23
24+# ftbs with ld --as-needed default, almost all private libs are underlinked
25+# and the dependecy reduction is negligible
26+# much simpler to just disable --as-needed than fixing them all
27+LDFLAGS+=-Wl,--no-as-needed
28+
29 llp=LD_LIBRARY_PATH
30 override_dh_auto_configure:
31 cd c++ && $(llp)=$(CURDIR)/c++/BUILD/lib$${$(llp)+:$$$(llp)} \

Subscribers

People subscribed via source and target branches

to all changes: