Code review comment for lp:~jtaylor/ubuntu/natty/meld/meld-sru

Revision history for this message
Chase Douglas (chasedouglas) wrote :

The proposed changes look good all around. A small issue is that the changelog should have UNRELEASED as the distro instead of natty-proposed unless it will be uploaded as is. Given the changelog email address, I doubt that's the case :). Whoever uploads the changes will be the one to flip it from UNRELEASED to natty-proposed.

The bug reports need proper SRU modifications. Please see https://wiki.ubuntu.com/StableReleaseUpdates?action=show&redirect=SRU#Procedure. In particular, a discussion of the regression potential of each fix is needed.

review: Needs Fixing

« Back to merge proposal