Code review comment for lp:~jtatum/mago/pidgin-exception

Hi,

I think for these particular imports that this conditional handling is appropriate. I'd like to be able to run these tests without adding packages that I may not otherwise have installed. The success/failure of a given pidgin installations should not be dependent on me having the MSN or XMPP modules available.

> Hello,
>
> I'm not sure I agree on this change. I would say that the correct way to solve
> this issue is at the package level, that is, adding those packages as
> dependencies to mago.
>
> In my opinion, catching ImportError exception should be done if there's an
> alternative library that could do the same job (for example some xml libraries
> implement the same ElementTree interface) so the problem can be solved at
> runtime. If the problem isn't really solved, then the exception should be
> raised as soon as possible to be able to locate the problem and fix it.
>
> Please let me know what do you think about this.
>
> Best regards,
> Javier