Code review comment for lp:~jtatum/mago/gconf

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello,

It looks fine to me. I also believe this is going to be useful for other tests. Thanks.

There's just one small problem when running the test that is available in the gconfwrapper module because class name is missing. Please see diff below:

=== modified file 'mago/gconfwrapper.py'
--- mago/gconfwrapper.py 2009-08-29 13:21:45 +0000
+++ mago/gconfwrapper.py 2009-09-01 15:06:53 +0000
@@ -164,9 +164,9 @@
     c['baz']=3.1

     print c['foo'], c['bar'], c['baz']
- print "Accessibility: %s" % get_item('/desktop/gnome/interface/accessibility')
+ print "Accessibility: %s" % GConf.get_item('/desktop/gnome/interface/accessibility')
     GConf.set_item('/apps/test-gconf/foobar', True)
     GConf.set_item('/apps/test-gconf/barfoo', False)

Best regards,
    Javier

review: Approve

« Back to merge proposal