Merge ~jsseidel/maas:jsseidel-add-pool-param-to-api-doc into maas:master

Proposed by Spencer Seidel
Status: Merged
Approved by: Spencer Seidel
Approved revision: e8e52785e9ff6a7de2e071adc830ee7c335f5726
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~jsseidel/maas:jsseidel-add-pool-param-to-api-doc
Merge into: maas:master
Diff against target: 14 lines (+4/-0)
1 file modified
src/maasserver/api/machines.py (+4/-0)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Newell Jensen (community) Approve
Review via email: mp+361801@code.launchpad.net

Commit message

Added 'pool' param to machines 'update' docstring in the API.

To post a comment you must log in.
e8e5278... by Spencer Seidel

Moved the pool param so that it doesn't come between power parameters params.

Revision history for this message
Newell Jensen (newell-jensen) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b jsseidel-add-pool-param-to-api-doc lp:~jsseidel/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e8e52785e9ff6a7de2e071adc830ee7c335f5726

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/api/machines.py b/src/maasserver/api/machines.py
2index a1f2021..aec4a29 100644
3--- a/src/maasserver/api/machines.py
4+++ b/src/maasserver/api/machines.py
5@@ -541,6 +541,10 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
6 checked against the expected power parameters for the machine's power
7 type ('true' or 'false'). The default is 'false'.
8
9+ @param (string) "pool" [required=false] The resource pool to which the
10+ machine should belong. All machines belong to the 'default' resource
11+ pool if they do not belong to any other resource pool.
12+
13 @param (string) "zone" [required=false] Name of a valid physical zone
14 in which to place this machine.
15

Subscribers

People subscribed via source and target branches