Merge ~jsseidel/maas:jsseidel-update-kvm-learn-more-links into maas:master

Proposed by Spencer Seidel
Status: Merged
Approved by: Spencer Seidel
Approved revision: 05aec1646f9d6b05078de8d77ce3468cec44a253
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~jsseidel/maas:jsseidel-update-kvm-learn-more-links
Merge into: maas:master
Diff against target: 38 lines (+4/-4)
2 files modified
src/maasserver/static/partials/node-details.html (+2/-2)
src/maasserver/static/partials/nodes-list.html (+2/-2)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+360200@code.launchpad.net

Commit message

Updated node-list node-details with better Learn more links that point to adding kvm host in docs

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/node-details.html b/src/maasserver/static/partials/node-details.html
2index d027ad5..240aadd 100755
3--- a/src/maasserver/static/partials/node-details.html
4+++ b/src/maasserver/static/partials/node-details.html
5@@ -124,12 +124,12 @@
6 <i class="p-icon--warning"></i>
7 <strong>Warning:</strong> Ubuntu 18.04 is the minimum required. <a target="_blank"
8 class="p-link--external"
9- href="https://docs.maas.io/2.5/en/manage-pods-webui#compose-a-machine">Learn more</a>
10+ href="https://docs.maas.io/2.5/en/manage-pods-webui#add-a-kvm-host">Learn more</a>
11 </span>
12 <span data-ng-if="nodesManager.isModernUbuntu(osSelection)">
13 <i class="p-icon--information">Information:</i>
14 <a target="_blank" class="p-link--external"
15- href="https://docs.maas.io/2.5/en/manage-pods-webui#compose-a-machine">Learn more</a>
16+ href="https://docs.maas.io/2.5/en/manage-pods-webui#add-a-kvm-host">Learn more</a>
17 </span>
18 </div>
19 </div>
20diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html
21index ab04299..263988a 100644
22--- a/src/maasserver/static/partials/nodes-list.html
23+++ b/src/maasserver/static/partials/nodes-list.html
24@@ -222,12 +222,12 @@
25 </label>
26 <span data-ng-if="!nodesManager.isModernUbuntu(tabs['machines'].osSelection)">
27 <i class="p-icon--warning"></i>
28- <strong>Warning:</strong> Ubuntu 18.04 is the minimum required. <a class="p-link--external" target="_blank" href="https://docs.maas.io/2.5/en/manage-pods-webui#compose-a-machine">Learn more</a>.
29+ <strong>Warning:</strong> Ubuntu 18.04 is the minimum required. <a class="p-link--external" target="_blank" href="https://docs.maas.io/2.5/en/manage-pods-webui#add-a-kvm-host">Learn more</a>.
30 </span>
31 <span data-ng-if="nodesManager.isModernUbuntu(tabs['machines'].osSelection)">
32 <i class="p-icon--information">Information:</i>
33 <a target="_blank" class="p-link--external"
34- href="https://docs.maas.io/2.5/en/manage-pods-webui#compose-a-machine">Learn more</a>
35+ href="https://docs.maas.io/2.5/en/manage-pods-webui#add-a-kvm-host">Learn more</a>
36 </span>
37 </div>
38 </div>

Subscribers

People subscribed via source and target branches