~jslarraz/review-tools:work-on-test-cases

Branch merges

Propose for merging

Merged into review-tools:master at revision 2979f040fdce69a935de810afca9430afae3a89c

Alex Murray: Needs Fixing on 2024-06-04

Diff: 491 lines (+128/-167)

4 files modified

reviewtools/containers/base_container.py (+12/-3)
reviewtools/containers/squashfs_container.py (+0/-11)
reviewtools/tests/containers/test_base_container.py (+97/-120)
reviewtools/tests/containers/test_squashfs_container.py (+19/-33)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

2979f04... by Jorge Sancho Larraz on 2024-06-02

rt/tests}/containers: improve coverage (missing extension and containerException)

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

8bf9b88... by Jorge Sancho Larraz on 2024-06-02

rt/tests}/containers: several improvements on exceptions handling

823fa93... by Jorge Sancho Larraz on 2024-06-02

rt/{,tests}/containers: move check_contaienr_format to BaseContainer initialization

c502c7b... by Jorge Sancho Larraz on 2024-06-04

tests/test.sh.expected: removed remaining "lint-snap-v2:assumes_valid"

15a3704... by Jorge Sancho Larraz on 2024-05-31

many: validate license and assumes via schema

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466736

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

7dcfef8... by Jorge Sancho Larraz on 2024-06-03

many: rename BaseContainer.get_yaml to get_file_as_yaml and add yaml_version and allow_duplicate_key arguments

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466662

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

7d298e8... by Jorge Sancho Larraz on 2024-05-30

many: add get_yaml to BaseContainer and use it to read snap.yaml and manifest.yaml

1407371... by Jorge Sancho Larraz on 2024-06-03

many: move Report class away from bin/snap-review, and use it also on individual checks

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466806

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

bac6469... by Jorge Sancho Larraz on 2024-05-31

bin/snap-review,modules: rework bin/snap-review towards a common report class used in all reviews

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466751

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

a5c1d02... by Jorge Sancho Larraz on 2024-05-31

bin/snap-review: remove duplicate `overrides` initialization