~jslarraz/review-tools:run-black

Branch merges

Propose for merging

Merged into review-tools:master at revision d438d79718c3412236809685c25bdb086472b426

Alex Murray: Approve on 2024-05-02

Diff: 380 lines (+69/-37)

13 files modified

reviewtools/modules.py (+1/-0)
reviewtools/overrides.py (+1/-1)
reviewtools/sr_common.py (+5/-3)
reviewtools/sr_functional.py (+1/-1)
reviewtools/sr_lint.py (+2/-1)
reviewtools/sr_security.py (+9/-5)
reviewtools/tests/test_debversion.py (+1/-1)
reviewtools/tests/test_email.py (+2/-2)
reviewtools/tests/test_sr_declaration.py (+0/-3)
reviewtools/tests/test_sr_functional.py (+4/-4)
reviewtools/tests/test_sr_lint.py (+26/-10)
reviewtools/tests/test_sr_security.py (+1/-1)
reviewtools/tests/test_store.py (+16/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

d438d79... by Jorge Sancho Larraz on 2024-05-02

Run black on code

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

da5276d... by Evan Caville on 2024-04-19

reviewtools/overrides.py: add public snaps and update redflagged kernel snaps

Signed-off-by: Evan Caville <email address hidden>

38c1077... by Alex Murray on 2024-04-11

Merge branch 'validate-parsed-plugs-slots-json-for-bare-scalars'

Signed-off-by: Alex Murray <email address hidden>

d3e08b4... by Alex Murray on 2024-04-11

tests: add integration test for bare scalars and fix expected output

Signed-off-by: Alex Murray <email address hidden>

ace8ea0... by Alex Murray on 2024-04-11

reviewtools/sr_declaration.py: improve error output on invalid json

Signed-off-by: Alex Murray <email address hidden>

bc1469b... by Alex Murray on 2024-04-11

bin/snap{review,verify-declaration}: fix error handling on invalid json

Signed-off-by: Alex Murray <email address hidden>

76d0522... by Alex Murray on 2024-04-11

many: when parsing plugs/slots json validate for bare scalars

The store will raise an error if the provided plugs/slots json contains bare
scalars - instead these need to be strings. So when parsing these from the user,
validate them against this condition so we can warn the user before they go and
try to update the declaration in the store using something that would ultimately
fail.

Signed-off-by: Alex Murray <email address hidden>

de1816d... by Emilia Torino on 2024-04-02

Adding missing comma after gadget override

Signed-off-by: Maria Emilia Torino <email address hidden>

d2c07ef... by Emilia Torino on 2024-03-27

update redflagged_snap_types_overrides

Signed-off-by: Maria Emilia Torino <email address hidden>

a918613... by Emilia Torino on 2024-03-14

add public snap

Signed-off-by: Maria Emilia Torino <email address hidden>