~jslarraz/review-tools:container-add-get-yaml

Branch merges

Propose for merging

Merged into review-tools:master at revision 7dcfef8c2cb776b042f606ca2db502fc05dd787c

Alex Murray: Approve on 2024-06-03

Diff: 431 lines (+159/-124)

6 files modified

dev/null (+0/-38)
reviewtools/containers/base_container.py (+43/-1)
reviewtools/sr_common.py (+10/-57)
reviewtools/sr_tests.py (+12/-23)
reviewtools/tests/containers/test_base_container.py (+93/-3)
reviewtools/tests/test_bbb_example_sr_skeleton.py (+1/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7dcfef8... by Jorge Sancho Larraz on 2024-06-03

many: rename BaseContainer.get_yaml to get_file_as_yaml and add yaml_version and allow_duplicate_key arguments

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466662

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

7d298e8... by Jorge Sancho Larraz on 2024-05-30

many: add get_yaml to BaseContainer and use it to read snap.yaml and manifest.yaml

1407371... by Jorge Sancho Larraz on 2024-06-03

many: move Report class away from bin/snap-review, and use it also on individual checks

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466806

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

bac6469... by Jorge Sancho Larraz on 2024-05-31

bin/snap-review,modules: rework bin/snap-review towards a common report class used in all reviews

MR: https://code.launchpad.net/~jslarraz/review-tools/+git/review-tools/+merge/466751

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

a5c1d02... by Jorge Sancho Larraz on 2024-05-31

bin/snap-review: remove duplicate `overrides` initialization

836a764... by Jorge Sancho Larraz on 2024-05-31

rt/sr_lint,tests/test.sh.expected: add lint error if meta/gui/xxx.desktop does not exist, instead of exiting with common.error

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

d1bfdaa... by Alex Murray on 2024-06-03

reviewtools/schemas: add __init__.py to signify this is a module

This ensures find_packages() in setup.py will find the associated
schema_validator.py within the schemas/ subdirectory and package it in the snap
etc.

Signed-off-by: Alex Murray <email address hidden>

f0fe85e... by Jorge Sancho Larraz on 2024-05-30

rt/c/base_container: use magic compat API and remove `charset=binary` from mime_types as 18.04 and higher doesn't show the charset

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

97ce21f... by Jorge Sancho Larraz on 2024-05-29

many: move size checks and unpack to relevant containers.

	test:0 (build)
	coverage:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

79ad906... by Jorge Sancho Larraz on 2024-05-29

rt/tests/c/test_base_container: dont' assume it is squashfs