Merge ~jslarraz/review-tools:allow-gadget into review-tools:master

[Jorge Sancho Larraz]

Adds the --allow-gadget parameter to snap-review as a quick way to bypass the check_type_redflagged for gadget snaps

[Alex Murray (alexmurray)]

LGTM as a temporary work-around. Thanks @jslarraz.

review: Approve

diff --git a/bin/snap-review b/bin/snap-review
index 299473e..8199929 100755
--- a/bin/snap-review
+++ b/bin/snap-review
@@ -63,6 +63,9 @@ def main():
     parser.add_argument(
         "--allow-classic", help="allow confinement: classic", action="store_true"
     )
+    parser.add_argument(
+        "--allow-gadget", help="don't flag gadget snaps", action="store_true"
+    )
     parser.add_argument("--on-store", default=None, help="store id for the snap")
     parser.add_argument("--on-brand", default=None, help="brand id for the snap")
     parser.add_argument("--state-input", default=None, help="store state input blob")
@@ -100,6 +103,8 @@ def main():
             error("Failed to read slots: %s" % e, output_type=error_output_type)
     if args.allow_classic:
         overrides["snap_allow_classic"] = args.allow_classic
+    if args.allow_gadget:
+        overrides["snap_allow_gadget"] = args.allow_gadget
     if args.on_store:
         overrides["snap_on_store"] = args.on_store
     if args.on_brand:
diff --git a/reviewtools/sr_lint.py b/reviewtools/sr_lint.py
index f5bc8ae..2da0ae1 100644
--- a/reviewtools/sr_lint.py
+++ b/reviewtools/sr_lint.py
@@ -103,6 +103,14 @@ class SnapReviewLint(SnapReview):
                 and pkgname in redflagged_snap_types_overrides[snaptype]
             ):
                 s = "OK (override '%s' for 'type: %s')" % (pkgname, snaptype)
+            # TODO: temporal work around to enable --allow-gadget in snap-review
+            elif (
+                snaptype == "gadget"
+                and self.overrides is not None
+                and "snap_allow_gadget" in self.overrides
+                and self.overrides["snap_allow_gadget"]
+            ):
+                s = "OK (override '%s' for 'type: %s')" % (pkgname, snaptype)
             else:
                 t = "error"
                 s = "(NEEDS REVIEW) type '%s' not allowed" % self.snap_yaml["type"]