Merge ~jslarraz/review-tools:add-intall-deps-target into review-tools:master

[Jorge Sancho Larraz]

Makefile: add install-{,deb,snap}-deps targets

[Jorge Sancho Larraz (jslarraz)]

> is this apt install or snap install instead?

Yup, it is snap install. updated :)

[Alex Murray (alexmurray)]

Should this use sudo for the apt install commands? Or better yet, to match the experience of snap install, should it use pkexec to prompt via gui?

review: Needs Information

[Jorge Sancho Larraz (jslarraz)]

Using pkexec would be nice, but unless I'm not aware of some option, it will prompt the user for every package that needs to be installed. It could be avoided by wrapping the loop in a bash script but I think it is an overkill considering the purpose of this target.

If there is a way to "cache" user password via pkexec I will be happy to take a look at it.

Otherwise "sudo" should be ok here

[Alex Murray (alexmurray)]

Ok - let's go with it as it already is - thanks @jslarraz.

review: Approve

diff --git a/Makefile b/Makefile
index 523b0ac..2e394fb 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,14 @@ check-snap-deps:
 
 check-deps: check-deb-deps check-snap-deps
 
+install-deb-deps:
+	@for dep in $(DEB_DEPENDENCIES); do if ! dpkg -s $$dep 1>/dev/null 2>&1; then sudo apt install -y $$dep; fi; done
+
+install-snap-deps:
+	@for dep in $(SNAP_DEPENDENCIES); do if ! snap list $$dep 1>/dev/null 2>&1; then sudo snap install $$dep; fi; done
+
+install-deps: install-deb-deps install-snap-deps
+
 black: clean
 	black --check $(FILES)