Code review comment for ~jslarraz/review-tools:add-doc-about-libmagic-warning

Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM, but can you please update the commit description to also describe how and why you are removing the 3 entries from magic_binary_file_descriptions as well? Thanks. A commit message more like

rt/c/base_container: use magic compat API

...

would perhaps make more sense here.

review: Needs Fixing

« Back to merge proposal